Use the -m option in xfconf-query to monitor for changes #5

rokosun · 2022-09-18T20:06:23Z

rokosun commented

2022-09-18 20:06:23 +00:00

I also improved the overall code syntax, there's no need for the old functions anymore.

❤️ 2

rokosun added 1 commit 2022-09-18 20:06:24 +00:00

Use the -m option in xfconf-query to monitor for changes 73471917ef

I also improved the overall code syntax, there's no need for the old functions anymore.

rokosun commented

2022-09-18 20:11:55 +00:00

@tio: Test this and let me know if you find any bugs, when you're satisfied with the script then you can merge it.

👍 1

eSh approved these changes 2022-09-18 22:00:31 +00:00

bin/periodic/fix-theming

						
				@ -20,2 +4,2 @@

					sed -i "s/^icon_theme=.*$/icon_theme=$icon_theme/" "$HOME"/.config/qt6ct/qt6ct.conf

				}

					# Check if the system theme has been changed

					if [ "$line" = 'set: /Net/ThemeName' ]; then

eSh commented

2022-09-18 22:00:20 +00:00

A minor thing: to replace if;then;fi with switch;case statement:

case EXPRESSION in

  PATTERN_1)
    STATEMENTS
    ;;

  PATTERN_2)
    STATEMENTS
    ;;

  PATTERN_N)
    STATEMENTS
    ;;

  *)
    STATEMENTS
    ;;
esac

More details and examples are here.

This just adds some structure and also an easier to update if some more settings changes will be necessary to subsctibe to. But I leave it up to you to decide, you can skip it if you want 😉

A minor thing: to replace `if;then;fi` with `switch;case` statement: ``` case EXPRESSION in PATTERN_1) STATEMENTS ;; PATTERN_2) STATEMENTS ;; PATTERN_N) STATEMENTS ;; *) STATEMENTS ;; esac ``` More details and examples are [here](https://linuxize.com/post/bash-case-statement/). This just adds some structure and also an easier to update if some more settings changes will be necessary to subsctibe to. But I leave it up to you to decide, you can skip it if you want 😉

rokosun commented

2022-09-18 22:36:11 +00:00

Oh of course it makes sense to use a case statement here, why didn't I think of it before? lol 😄

😆 1

eSh commented

2022-09-18 22:39:00 +00:00

Oh, man.. Happens to me too quite often 😅

😆 1

rokosun marked this conversation as resolved

eSh added the

enhancement

label 2022-09-18 22:01:59 +00:00