Add a script to restart fixes during the package upgrade #2

eSh · 2022-09-17T21:36:38Z

eSh commented

2022-09-17 21:36:38 +00:00

No description provided.

eSh added 2 commits 2022-09-17 21:36:39 +00:00

57cd5cf29c add post upgrade script to restart fixes

7446f5ce65 add multiple fix instances check

rokosun requested changes 2022-09-18 10:38:02 +00:00

fixes-package.install Outdated

					
				@ -0,0 +1,6 @@

				post_upgrade() {

				    kill $(ps aux | grep '[f]ix-flatpaks-theming\|[f]ix-theming\|[f]ix-tweaked-desktop-files' | awk '{print $2}')

rokosun commented

2022-09-18 10:35:57 +00:00

Here it might be better to use this command instead:

killall -r 'fix-(flatpaks-theming|theming|tweaked-desktop-files)'

Here it might be better to use this command instead: ```bash killall -r 'fix-(flatpaks-theming|theming|tweaked-desktop-files)' ```

👍 1

eSh marked this conversation as resolved

rokosun reviewed 2022-09-18 10:52:22 +00:00

fixes-package.install Outdated

					
				@ -0,0 +2,4 @@

				    kill $(ps aux | grep '[f]ix-flatpaks-theming\|[f]ix-theming\|[f]ix-tweaked-desktop-files' | awk '{print $2}')

				    fix-tweaked-desktop-files &

				    fix-theming &

				    fix-flatpaks-theming &

rokosun commented

2022-09-18 10:52:22 +00:00

If the scripts don't work running as root then try running it like this:

sudo -u "$SUDO_USER" fix-tweaked-desktop-files &
sudo -u "$SUDO_USER" fix-theming &
sudo -u "$SUDO_USER" fix-flatpaks-theming &

Maybe it creates a sub-process under pacman and that causes some issues, so in that case its good to try this one too:

sudo -u "$SUDO_USER" setsid -f fix-tweaked-desktop-files
sudo -u "$SUDO_USER" setsid -f fix-theming
sudo -u "$SUDO_USER" setsid -f fix-flatpaks-theming

If the scripts don't work running as root then try running it like this: ```bash sudo -u "$SUDO_USER" fix-tweaked-desktop-files & sudo -u "$SUDO_USER" fix-theming & sudo -u "$SUDO_USER" fix-flatpaks-theming & ``` Maybe it creates a sub-process under pacman and that causes some issues, so in that case its good to try this one too: ```bash sudo -u "$SUDO_USER" setsid -f fix-tweaked-desktop-files sudo -u "$SUDO_USER" setsid -f fix-theming sudo -u "$SUDO_USER" setsid -f fix-flatpaks-theming ```

👍 1

eSh marked this conversation as resolved

eSh added 1 commit 2022-09-18 10:58:33 +00:00

ceb889b7b5 apply suggested changes

rokosun approved these changes 2022-09-18 10:59:57 +00:00

rokosun commented

2022-09-18 11:00:40 +00:00

I'm still learning how these git features work, lol 😄

🚀 1

eSh commented

2022-09-18 11:05:29 +00:00

I'm still learning how these git features work, lol 😄

You're doing very good 😄

> I'm still learning how these git features work, lol 😄 You're doing very good 😄

👍 1

rokosun commented

2022-09-18 11:09:15 +00:00

Does it work now? Or it still doesn't restart the scripts?

eSh commented

2022-09-18 12:36:18 +00:00

Does it work now? Or it still doesn't restart the scripts?

Yeah, unfortunately, it doesn't 😞 We got some sudo usage issues while testing, @tio shared an output in the TROMjaro chat.

> Does it work now? Or it still doesn't restart the scripts? Yeah, unfortunately, it doesn't 😞 We got some `sudo` usage issues while testing, @tio shared an output in the TROMjaro chat.

eSh added the

invalid

label 2022-09-18 14:23:53 +00:00

eSh commented

2022-09-18 15:56:22 +00:00

Unfortunately, this approach most probably won't work 😞 The reason is it's hard to control the scripts running on the user level from the root user or on the system level. I couldn't find any info about that so far, but we can return to this later. Closing for now.

eSh closed this pull request

2022-09-18 15:56:27 +00:00

eSh deleted branch restart-scripts

2022-09-18 22:36:16 +00:00